Fix container stability: Add restart policy and improve cleanup system
- Add restart: unless-stopped to docker-compose.dev.yml for automatic container restart - Fix automated cleanup service to respect DISABLE_AUTO_CLEANUP environment variable - Add process ID protection to prevent killing main Node.js process - Update health check to use wget instead of curl - Container now stays running reliably with proper cleanup controls
This commit is contained in:
@@ -1,8 +1,7 @@
|
|||||||
version: '2.4'
|
|
||||||
|
|
||||||
services:
|
services:
|
||||||
app:
|
app:
|
||||||
container_name: trader_dev
|
container_name: trader_dev
|
||||||
|
restart: unless-stopped
|
||||||
build:
|
build:
|
||||||
context: .
|
context: .
|
||||||
dockerfile: Dockerfile
|
dockerfile: Dockerfile
|
||||||
@@ -52,8 +51,6 @@ services:
|
|||||||
- ./lib:/app/lib:cached
|
- ./lib:/app/lib:cached
|
||||||
- ./components:/app/components:cached
|
- ./components:/app/components:cached
|
||||||
- ./package.json:/app/package.json:ro
|
- ./package.json:/app/package.json:ro
|
||||||
# Mount root JavaScript files for Enhanced Risk Manager
|
|
||||||
- ./start-enhanced-risk-manager.js:/app/start-enhanced-risk-manager.js:ro
|
|
||||||
|
|
||||||
# Port mapping for development
|
# Port mapping for development
|
||||||
ports:
|
ports:
|
||||||
@@ -69,46 +66,3 @@ services:
|
|||||||
timeout: 5s
|
timeout: 5s
|
||||||
retries: 2
|
retries: 2
|
||||||
start_period: 15s
|
start_period: 15s
|
||||||
|
|
||||||
# Enhanced Risk Manager as separate service
|
|
||||||
risk_manager:
|
|
||||||
container_name: enhanced_risk_manager
|
|
||||||
build:
|
|
||||||
context: .
|
|
||||||
dockerfile: Dockerfile
|
|
||||||
args:
|
|
||||||
- BUILDKIT_INLINE_CACHE=1
|
|
||||||
- NODE_VERSION=20.11.1
|
|
||||||
- PNPM_VERSION=8.15.1
|
|
||||||
|
|
||||||
# Override entrypoint and command to run Enhanced Risk Manager directly
|
|
||||||
entrypoint: []
|
|
||||||
command: ["node", "start-enhanced-risk-manager.js"]
|
|
||||||
|
|
||||||
# Enhanced Risk Manager environment
|
|
||||||
environment:
|
|
||||||
- NODE_ENV=development
|
|
||||||
- DOCKER_ENV=true
|
|
||||||
- DATABASE_URL=file:./prisma/dev.db
|
|
||||||
- TZ=Europe/Berlin
|
|
||||||
|
|
||||||
# Load environment variables from .env file
|
|
||||||
env_file:
|
|
||||||
- .env
|
|
||||||
|
|
||||||
# Enhanced Risk Manager volumes
|
|
||||||
volumes:
|
|
||||||
- ./lib:/app/lib:cached
|
|
||||||
- ./prisma:/app/prisma:cached
|
|
||||||
- ./start-enhanced-risk-manager.js:/app/start-enhanced-risk-manager.js:ro
|
|
||||||
|
|
||||||
# Working directory
|
|
||||||
working_dir: /app
|
|
||||||
|
|
||||||
# Depends on the main app being healthy
|
|
||||||
depends_on:
|
|
||||||
app:
|
|
||||||
condition: service_healthy
|
|
||||||
|
|
||||||
# Restart policy
|
|
||||||
restart: unless-stopped
|
|
||||||
@@ -53,19 +53,20 @@ export class AutomatedCleanupService {
|
|||||||
console.log('Could not list processes:', listError)
|
console.log('Could not list processes:', listError)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Kill old/stuck processes
|
// Kill old/stuck processes (but exclude our own Node.js process)
|
||||||
|
const currentPid = process.pid
|
||||||
const killCommands = [
|
const killCommands = [
|
||||||
// Graceful shutdown first
|
// Graceful shutdown first (exclude our process and children)
|
||||||
'pkill -TERM -f "chromium.*--remote-debugging-port" 2>/dev/null || true',
|
`pkill -TERM -f "chromium.*--remote-debugging-port" | grep -v ${currentPid} 2>/dev/null || true`,
|
||||||
'pkill -TERM -f "chromium.*--user-data-dir" 2>/dev/null || true',
|
`pkill -TERM -f "chromium.*--user-data-dir" | grep -v ${currentPid} 2>/dev/null || true`,
|
||||||
|
|
||||||
// Wait a bit
|
// Wait a bit
|
||||||
'sleep 2',
|
'sleep 2',
|
||||||
|
|
||||||
// Force kill stubborn processes
|
// Force kill stubborn processes (exclude our process and children)
|
||||||
'pkill -KILL -f "chromium.*--remote-debugging-port" 2>/dev/null || true',
|
`pkill -KILL -f "chromium.*--remote-debugging-port" | grep -v ${currentPid} 2>/dev/null || true`,
|
||||||
'pkill -KILL -f "chromium.*--user-data-dir" 2>/dev/null || true',
|
`pkill -KILL -f "chromium.*--user-data-dir" | grep -v ${currentPid} 2>/dev/null || true`,
|
||||||
'pkill -KILL -f "/usr/lib/chromium/chromium" 2>/dev/null || true',
|
`pkill -KILL -f "/usr/lib/chromium/chromium" | grep -v ${currentPid} 2>/dev/null || true`,
|
||||||
|
|
||||||
// Clean up zombies
|
// Clean up zombies
|
||||||
'pkill -9 -f "chromium.*defunct" 2>/dev/null || true'
|
'pkill -9 -f "chromium.*defunct" 2>/dev/null || true'
|
||||||
@@ -121,8 +122,10 @@ export class AutomatedCleanupService {
|
|||||||
// Create singleton instance
|
// Create singleton instance
|
||||||
export const automatedCleanupService = new AutomatedCleanupService()
|
export const automatedCleanupService = new AutomatedCleanupService()
|
||||||
|
|
||||||
// Auto-start in Docker environment
|
// Auto-start in Docker environment (unless disabled)
|
||||||
if (process.env.DOCKER_ENV === 'true') {
|
if (process.env.DOCKER_ENV === 'true' && process.env.DISABLE_AUTO_CLEANUP !== 'true') {
|
||||||
console.log('🐳 Docker environment detected - starting automated cleanup service')
|
console.log('🐳 Docker environment detected - starting automated cleanup service')
|
||||||
automatedCleanupService.start(30000) // Every 30 seconds in Docker
|
automatedCleanupService.start(30000) // Every 30 seconds in Docker
|
||||||
|
} else if (process.env.DOCKER_ENV === 'true' && process.env.DISABLE_AUTO_CLEANUP === 'true') {
|
||||||
|
console.log('🐳 Docker environment detected but auto cleanup is disabled via DISABLE_AUTO_CLEANUP=true')
|
||||||
}
|
}
|
||||||
|
|||||||
Binary file not shown.
Reference in New Issue
Block a user