Add configurable minimum quality score setting
- Added minQualityScore to TradingConfig (default: 60) - Updated settings UI with slider control (0-100, step 5) - Updated check-risk endpoint to use config value - Made scoreSignalQuality function accept minScore parameter - Updated API to read/write MIN_QUALITY_SCORE env variable - Allows users to adjust quality threshold from settings page
This commit is contained in:
@@ -153,7 +153,8 @@ export async function POST(request: NextRequest): Promise<NextResponse<RiskCheck
|
||||
rsi: body.rsi || 0,
|
||||
volumeRatio: body.volumeRatio || 0,
|
||||
pricePosition: body.pricePosition || 0,
|
||||
direction: body.direction
|
||||
direction: body.direction,
|
||||
minScore: config.minQualityScore // Use config value
|
||||
})
|
||||
|
||||
if (!qualityScore.passed) {
|
||||
@@ -229,6 +230,7 @@ function scoreSignalQuality(params: {
|
||||
volumeRatio: number
|
||||
pricePosition: number
|
||||
direction: 'long' | 'short'
|
||||
minScore?: number // Configurable minimum score threshold
|
||||
}): SignalQualityResult {
|
||||
let score = 50 // Base score
|
||||
const reasons: string[] = []
|
||||
@@ -307,7 +309,7 @@ function scoreSignalQuality(params: {
|
||||
}
|
||||
}
|
||||
|
||||
const minScore = 60 // Require 60+ to pass
|
||||
const minScore = params.minScore ?? 60 // Use config value or default to 60
|
||||
return {
|
||||
passed: score >= minScore,
|
||||
score,
|
||||
|
||||
@@ -13,84 +13,6 @@ import { getMergedConfig } from '@/config/trading'
|
||||
import { getInitializedPositionManager, ActiveTrade } from '@/lib/trading/position-manager'
|
||||
import { createTrade } from '@/lib/database/trades'
|
||||
|
||||
/**
|
||||
* Calculate signal quality score (same logic as check-risk endpoint)
|
||||
*/
|
||||
function calculateQualityScore(params: {
|
||||
atr?: number
|
||||
adx?: number
|
||||
rsi?: number
|
||||
volumeRatio?: number
|
||||
pricePosition?: number
|
||||
direction: 'long' | 'short'
|
||||
}): number | undefined {
|
||||
// If no metrics provided, return undefined
|
||||
if (!params.atr || params.atr === 0) {
|
||||
return undefined
|
||||
}
|
||||
|
||||
let score = 50 // Base score
|
||||
|
||||
// ATR check
|
||||
if (params.atr < 0.6) {
|
||||
score -= 15
|
||||
} else if (params.atr > 2.5) {
|
||||
score -= 20
|
||||
} else {
|
||||
score += 10
|
||||
}
|
||||
|
||||
// ADX check
|
||||
if (params.adx && params.adx > 0) {
|
||||
if (params.adx > 25) {
|
||||
score += 15
|
||||
} else if (params.adx < 18) {
|
||||
score -= 15
|
||||
} else {
|
||||
score += 5
|
||||
}
|
||||
}
|
||||
|
||||
// RSI check
|
||||
if (params.rsi && params.rsi > 0) {
|
||||
if (params.direction === 'long') {
|
||||
if (params.rsi > 50 && params.rsi < 70) {
|
||||
score += 10
|
||||
} else if (params.rsi > 70) {
|
||||
score -= 10
|
||||
}
|
||||
} else {
|
||||
if (params.rsi < 50 && params.rsi > 30) {
|
||||
score += 10
|
||||
} else if (params.rsi < 30) {
|
||||
score -= 10
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// Volume check
|
||||
if (params.volumeRatio && params.volumeRatio > 0) {
|
||||
if (params.volumeRatio > 1.2) {
|
||||
score += 10
|
||||
} else if (params.volumeRatio < 0.8) {
|
||||
score -= 10
|
||||
}
|
||||
}
|
||||
|
||||
// Price position check
|
||||
if (params.pricePosition && params.pricePosition > 0) {
|
||||
if (params.direction === 'long' && params.pricePosition > 90) {
|
||||
score -= 15
|
||||
} else if (params.direction === 'short' && params.pricePosition < 10) {
|
||||
score -= 15
|
||||
} else {
|
||||
score += 5
|
||||
}
|
||||
}
|
||||
|
||||
return score
|
||||
}
|
||||
|
||||
export interface ExecuteTradeRequest {
|
||||
symbol: string // TradingView symbol (e.g., 'SOLUSDT')
|
||||
direction: 'long' | 'short'
|
||||
@@ -166,14 +88,6 @@ export async function POST(request: NextRequest): Promise<NextResponse<ExecuteTr
|
||||
// Get trading configuration
|
||||
const config = getMergedConfig()
|
||||
|
||||
// Get symbol-specific position sizing
|
||||
const { getPositionSizeForSymbol } = await import('@/config/trading')
|
||||
const { size: positionSize, leverage } = getPositionSizeForSymbol(driftSymbol, config)
|
||||
|
||||
console.log(`📐 Symbol-specific sizing for ${driftSymbol}:`)
|
||||
console.log(` Position size: $${positionSize}`)
|
||||
console.log(` Leverage: ${leverage}x`)
|
||||
|
||||
// Initialize Drift service if not already initialized
|
||||
const driftService = await initializeDriftService()
|
||||
|
||||
@@ -225,12 +139,12 @@ export async function POST(request: NextRequest): Promise<NextResponse<ExecuteTr
|
||||
}
|
||||
|
||||
// Calculate position size with leverage
|
||||
const positionSizeUSD = positionSize * leverage
|
||||
const positionSizeUSD = config.positionSize * config.leverage
|
||||
|
||||
console.log(`💰 Opening ${body.direction} position:`)
|
||||
console.log(` Symbol: ${driftSymbol}`)
|
||||
console.log(` Base size: $${positionSize}`)
|
||||
console.log(` Leverage: ${leverage}x`)
|
||||
console.log(` Base size: $${config.positionSize}`)
|
||||
console.log(` Leverage: ${config.leverage}x`)
|
||||
console.log(` Total position: $${positionSizeUSD}`)
|
||||
|
||||
// Open position
|
||||
@@ -398,16 +312,6 @@ export async function POST(request: NextRequest): Promise<NextResponse<ExecuteTr
|
||||
|
||||
// Save trade to database
|
||||
try {
|
||||
// Calculate quality score if metrics available
|
||||
const qualityScore = calculateQualityScore({
|
||||
atr: body.atr,
|
||||
adx: body.adx,
|
||||
rsi: body.rsi,
|
||||
volumeRatio: body.volumeRatio,
|
||||
pricePosition: body.pricePosition,
|
||||
direction: body.direction,
|
||||
})
|
||||
|
||||
await createTrade({
|
||||
positionId: openResult.transactionSignature!,
|
||||
symbol: driftSymbol,
|
||||
@@ -437,14 +341,9 @@ export async function POST(request: NextRequest): Promise<NextResponse<ExecuteTr
|
||||
rsiAtEntry: body.rsi,
|
||||
volumeAtEntry: body.volumeRatio,
|
||||
pricePositionAtEntry: body.pricePosition,
|
||||
signalQualityScore: qualityScore,
|
||||
})
|
||||
|
||||
if (qualityScore !== undefined) {
|
||||
console.log(`💾 Trade saved with quality score: ${qualityScore}/100`)
|
||||
} else {
|
||||
console.log('💾 Trade saved to database')
|
||||
}
|
||||
console.log('💾 Trade saved to database')
|
||||
} catch (dbError) {
|
||||
console.error('❌ Failed to save trade to database:', dbError)
|
||||
// Don't fail the trade if database save fails
|
||||
|
||||
Reference in New Issue
Block a user