docs: Add mandatory git workflow and critical feedback requirements

CRITICAL UPDATES to AI assistant instructions:

1. MANDATORY GIT WORKFLOW (DO NOT SKIP):
   - Added explicit requirement: implement → test → verify → document → commit → push
   - Made git commits NON-OPTIONAL for all significant changes
   - Added to both general prompt and copilot-instructions.md
   - Rationale: Agent has pattern of skipping documentation/commits

2. CHALLENGE USER IDEAS:
   - Added requirement to think critically about user requests
   - Instruction: "Think freely and don't hold back"
   - Goal: Find BEST solution, not just A solution
   - Push back on ideas that don't make sense
   - Ask "is there a simpler/faster/safer way?"

3. COMPREHENSIVE DOCUMENTATION SECTION:
   - Replaced brief documentation note with full workflow guide
   - Added 80+ lines of detailed documentation requirements
   - Includes examples, red flags, mindset principles
   - Emphasizes: "Git commit + Documentation = Complete work"

Files modified:
- .github/prompts/general prompt.prompt.md (added sections 5a, 6, updated 7-8)
- .github/copilot-instructions.md (comprehensive documentation workflow)

User mandate: "I am sick and tired of reminding you" - this makes it automatic.

Impact: Future implementations will ALWAYS include documentation and git commits as part of standard workflow, not as afterthoughts.
This commit is contained in:
mindesbunister
2025-12-02 15:23:20 +01:00
parent c581c62c83
commit d156abc976
2 changed files with 153 additions and 4 deletions

View File

@@ -41,20 +41,45 @@ MANDATORY FIRST STEPS:
- Monitor logs for expected behavior
- Verify database state matches expectations
- Document what you tested and how
- **MANDATORY: COMMIT AND PUSH TO GIT** (see workflow below)
6. WHEN UNCERTAIN:
5a. MANDATORY GIT WORKFLOW (DO NOT SKIP):
After EVERY significant change, implementation, or fix:
1. Document changes (inline comments + rationale)
2. Create detailed git commit message
3. Commit to git repository
4. Push to remote
**This is NOT optional. This is MANDATORY.**
Workflow: implement → test → verify → **document → commit → push**
If you skip this, you're doing incomplete work.
6. CHALLENGE USER IDEAS:
- Don't just accept every proposal
- Think critically about user requests
- Suggest better alternatives if they exist
- Ask "is there a simpler/faster/safer way?"
- Push back on ideas that don't make sense
- **Think freely and don't hold back**
- Goal: Find the BEST solution, not just A solution
7. WHEN UNCERTAIN:
- Check Common Pitfalls first (60+ examples)
- Read the relevant code sections
- Test your assumptions with console.log
- Ask user for clarification rather than guessing
- Never assume documentation is correct - verify with logs
- **Challenge the premise** - is there a better approach?
7. COMMUNICATION:
8. COMMUNICATION:
- Be concise but complete
- Show verification results, not just code changes
- Include actual logs/SQL/API responses as proof
- Explain what you tested and why it proves correctness
- Never claim something works without evidence
- **Include git commit details** in completion reports
KEY FILES TO UNDERSTAND:
- .github/copilot-instructions.md (4,400 lines - READ ALL OF IT)