From d7d8369cc7f275ed323694fcfb0440ec4a1858a5 Mon Sep 17 00:00:00 2001 From: mindesbunister Date: Fri, 5 Dec 2025 10:40:02 +0100 Subject: [PATCH] fix: Correct BlockedSignal data contamination numbers - Only 31 records from multi-timeframe alerts (not 11,429) - 11,398 records are 1-minute data (kept as DATA_COLLECTION_ONLY) - Total marked as OLD_V9_VERSION: 31 (15min/1H/4H/Daily only) --- .github/copilot-instructions.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md index e53eea8..ffc7329 100644 --- a/.github/copilot-instructions.md +++ b/.github/copilot-instructions.md @@ -636,8 +636,8 @@ docs/COMMON_PITFALLS.md **Purpose:** Track exact minute-by-minute price movements for blocked signals to determine EXACTLY when TP1/TP2 would have been hit **CRITICAL: Data Contamination Discovery (Dec 5, 2025):** -- **Problem:** All TradingView alerts (5min, 15min, 1H, 4H, Daily) were attached to OLD v9 version with different settings -- **Impact:** 11,429 BlockedSignal records collected from wrong indicator parameters (confirmBars=0 instead of current v9) +- **Problem:** All TradingView alerts (15min, 1H, 4H, Daily) were attached to OLD v9 version with different settings +- **Impact:** 31 BlockedSignal records from wrong indicator version (multi-timeframe data collection) - **Solution:** Marked contaminated data with `blockReason='DATA_COLLECTION_OLD_V9_VERSION'` - **Exception:** 1-minute data (11,398 records) kept as `DATA_COLLECTION_ONLY` - not affected by alert version issue (pure market data sampling) - **SQL Filter:** Exclude old data: `WHERE blockReason != 'DATA_COLLECTION_OLD_V9_VERSION'`