root/trading_bot_v4
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: Add verification status for Common Pitfall #53 fixes (Dec 3, 2025)

Browse Source
This commit is contained in:
mindesbunister
2025-12-03 23:03:40 +01:00
parent aa61194aa6
commit e48332e347
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
.github/copilot-instructions.md vendored
View File

@@ -3918,6 +3918,12 @@ trade.realizedPnL += actualRealizedPnL // NOT: result.realizedPnL from SDK
```
- **Commit:** eccecf7 "critical: Fix container restart killing positions + phantom detection"
- **Deployed:** November 19, 2025
- **Verification (December 3, 2025):**
* ✅ Bug 1 Fix Confirmed: `lib/startup/init-position-manager.ts` lines 197-202 use correct field names (tp1OrderTx, tp2OrderTx, slOrderTx)
* ✅ Bug 2 Fix Confirmed: `lib/trading/position-manager.ts` line 872 includes `!trade.tp1Hit` check in phantom detection
* ✅ Both fixes active in production (container running since Dec 3, 2025 19:38:14 UTC)
* ✅ Git history shows commit eccecf7 in lineage of current deployment (aa61194)
- **Prevention:**
* Schema errors now fixed - orders restore correctly
* Phantom detection only checks pre-TP1 positions