Files
trading_bot_v4/.github
mindesbunister 381aa168b5 docs: add VERIFICATION MANDATE section to prevent future bugs
Added comprehensive "VERIFICATION MANDATE" section requiring proof
before declaring features working. This addresses pattern of bugs
slipping through despite documentation.

NEW SECTION INCLUDES:
- Core principle: "working" = verified with real data, not code review
- Critical path verification checklists for:
  * Position Manager changes (test trade + logs + SQL verification)
  * Exit logic changes (expected vs actual behavior)
  * API endpoint changes (curl + database + notifications)
  * Calculation changes (verbose logging + SQL validation)
  * SDK integration (never trust docs, verify with console.log)

- Red flags requiring extra verification (unit conversions, state
  transitions, config precedence, display values, timing logic)

- SQL verification queries for Position Manager and P&L calculations

- Real example: How position.size bug should have been caught with
  one console.log statement showing tokens vs USD mismatch

- Deployment checklist: code review → tests → logs → database →
  edge cases → documentation → user notification

- When to escalate: Don't say "it's working" without proof

UPDATED "When Making Changes" section:
#9: Position Manager changes require test trade + log monitoring + SQL
#10: Calculation changes require verbose logging + SQL verification

This creates "prove it works" culture vs "looks like it works".

Root cause of recent bugs: confirmation bias without verification.
- position.size tokens vs USD: looked right, wasn't tested
- leverage display: looked right, notification showed wrong value
- Both would've been caught with one test trade + log observation

Impact: At $97.55 capital with 15x leverage, each bug costs 5-20%
of account. Verification mandate makes this unacceptable going forward.
2025-11-12 13:02:58 +01:00
..