Add duplicate position prevention to risk check

- Updated risk check API to verify no existing positions on same symbol
- Use getInitializedPositionManager() to wait for trade restoration
- Updated .dockerignore to exclude test files and archive/
- Moved test-*.ts files to archive directory
- Prevents multiple positions from being opened on same symbol even if signals are valid
This commit is contained in:
mindesbunister
2025-10-27 19:08:07 +01:00
parent 17b0806ff3
commit 8f90339d8d

View File

@@ -7,6 +7,7 @@
import { NextRequest, NextResponse } from 'next/server'
import { getMergedConfig } from '@/config/trading'
import { getInitializedPositionManager } from '@/lib/trading/position-manager'
export interface RiskCheckRequest {
symbol: string
@@ -41,23 +42,37 @@ export async function POST(request: NextRequest): Promise<NextResponse<RiskCheck
const config = getMergedConfig()
// TODO: Implement actual risk checks:
// Check for existing positions on the same symbol
const positionManager = await getInitializedPositionManager()
const existingTrades = Array.from(positionManager.getActiveTrades().values())
const duplicatePosition = existingTrades.find(trade => trade.symbol === body.symbol)
if (duplicatePosition) {
console.log('🚫 Risk check BLOCKED: Duplicate position exists', {
symbol: body.symbol,
existingDirection: duplicatePosition.direction,
requestedDirection: body.direction,
existingEntry: duplicatePosition.entryPrice,
})
return NextResponse.json({
allowed: false,
reason: 'Duplicate position',
details: `Already have ${duplicatePosition.direction} position on ${body.symbol} (entry: $${duplicatePosition.entryPrice})`,
})
}
// TODO: Implement additional risk checks:
// 1. Check daily drawdown
// 2. Check trades per hour limit
// 3. Check cooldown period
// 4. Check account health
// 5. Check existing positions
// For now, always allow (will implement in next phase)
const allowed = true
const reason = allowed ? undefined : 'Risk limit exceeded'
console.log(`✅ Risk check: ${allowed ? 'PASSED' : 'BLOCKED'}`)
console.log(`✅ Risk check PASSED: No duplicate positions`)
return NextResponse.json({
allowed,
reason,
details: allowed ? 'All risk checks passed' : undefined,
allowed: true,
details: 'All risk checks passed',
})
} catch (error) {