mindesbunister 625566224a critical: Fix MFE/MAE storing dollars instead of percentages ...

Root Cause (Nov 23, 2025):
- Database showed MFE 64.08% when TradingView showed 0.48%
- Position Manager was storing DOLLAR amounts ($64.08) not percentages
- Prisma schema comment says 'Best profit % reached' but code stored dollars
- Bug caused 100× inflation in MFE/MAE analysis (0.83% shown as 83%)

The Bug (lib/trading/position-manager.ts line 1127):
- BEFORE: trade.maxFavorableExcursion = currentPnLDollars  // Storing $64.08
- AFTER:  trade.maxFavorableExcursion = profitPercent      // Storing 0.48%

Impact:
- All quality 90 analysis was based on wrong MFE values
- Trade #2 (Nov 22): Database showed 0.83% MFE, actual was 0.48%
- TP1-only simulation used inflated MFE values
- User observation (TradingView charts) revealed the discrepancy

Fix:
- Changed to store profitPercent (0.48) instead of currentPnLDollars ($64.08)
- Updated comment to reflect PERCENTAGE storage
- All future trades will track MFE/MAE correctly
- Historical data still has inflated values (can't auto-correct)

Validation Required:
- Next trade: Verify MFE/MAE stored as percentages
- Compare database values to TradingView chart max profit
- Quality 90 analysis should use corrected MFE data going forward

2025-11-23 14:18:04 +01:00

76 KiB

Raw Blame History

View Raw